Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Update nm-nightly.yml #308

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Update nm-nightly.yml #308

merged 1 commit into from
Jun 17, 2024

Conversation

derekk-nm
Copy link

Updates nm-nightly.yml to use the new test_skip_env_vars attribute, instead of test_skip_list, for the python 3.8 block.

this is the same attribute used for the other pythons, and is what's now provided by the calling nm-build-test.yml

to use the new test_skip_env_vars attribute, instead of test_skip_list, for python 3.8 block.
Copy link
Collaborator

@robertgshaw2-redhat robertgshaw2-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@derekk-nm derekk-nm merged commit 20f3e4f into main Jun 17, 2024
33 of 37 checks passed
@derekk-nm derekk-nm deleted the use_test_skip_env_vars_with_py38 branch June 17, 2024 21:55
@derekk-nm
Copy link
Author

The failed tests are unrelated, and the fact that the python 3.8 tests ran shows that the fix worked.

derekk-nm added a commit that referenced this pull request Jun 24, 2024
Updates `nm-nightly.yml` to use the new `test_skip_env_vars` attribute,
instead of `test_skip_list`, for the python 3.8 block.

this is the same attribute used for the other pythons, and is what's now
provided by the calling `nm-build-test.yml`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants